Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: osmapiR: An 'OpenStreetMap API' implementation for R #7036

Closed
editorialbot opened this issue Jul 25, 2024 · 22 comments
Closed
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 25, 2024

Submitting author: @jmaspons (Joan Maspons)
Repository: https://github.com/ropensci/osmapiR
Branch with paper.md (empty if default branch): joss
Version: v0.2.0
Editor: @arfon
Reviewers: @jonthegeek, @ccamara
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35"><img src="https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35/status.svg)](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35)

Author instructions

Thanks for submitting your paper to JOSS @jmaspons. Currently, there isn't a JOSS editor assigned to your paper.

@jmaspons if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.56 s (382.3 files/s, 459354.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               71           1523           4558         131563
XML                             89             32              0          88849
JSON                            31              3              0          25059
Markdown                        10            260              0           3214
SVG                              1             26              1           1104
YAML                             7             34             24            359
TeX                              1              7              0             75
Rmd                              4            110            302             45
-------------------------------------------------------------------------------
SUM:                           214           1995           4885         250268
-------------------------------------------------------------------------------

Commit count by author:

   308	Joan Maspons
     3	Carlos Cámara
     2	Maëlle Salmon
     1	Neal Richardson

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/CRAN.package.osmapiR is OK
- 10.21105/joss.00305 is OK
- 10.32614/CRAN.package.osmextract is OK
- 10.32614/CRAN.package.OpenStreetMap is OK
- 10.32614/RJ-2018-009 is OK
- 10.32614/CRAN.package.xml2 is OK
- 10.32614/RJ-2019-041 is OK

MISSING DOIs

- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 311

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

@arfon
Copy link
Member

arfon commented Jul 25, 2024

@jmaspons - many thanks for your submission to JOSS. It looks like the paper isn't currently compiling, could you please take a look at this example paper https://joss.readthedocs.io/en/latest/example_paper.html for the exact formatting requirements and update your paper accordingly (both metadata/YAML but also the structure/content)?

@jmaspons
Copy link

Works with the gh action in my repo https://github.com/ropensci/osmapiR/actions/runs/10090439427

⚠️ An error happened when generating the pdf.

Seems a problem with the (lack of) affiliation. I will try to fix it

@jmaspons
Copy link

Seems related to openjournals/joss#406. Hopefully fixed with the workaround

@jmaspons
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

OpenTripPlanner for R
Submitting author: @mem48
Handling editor: @danielskatz (Active)
Reviewers: @danielskatz
Similarity score: 0.7265

PostcodesioR: An R package for UK geocoding
Submitting author: @erzk
Handling editor: @oliviaguest (Active)
Reviewers: @oliviaguest
Similarity score: 0.7095

osfr: An R Interface to the Open Science Framework
Submitting author: @aaronwolen
Handling editor: @kthyng (Active)
Reviewers: @kthyng
Similarity score: 0.7080

home2park: An R package to assess the spatial provision of urban parks
Submitting author: @xp-song
Handling editor: @martinfleis (Active)
Reviewers: @aelissa, @nickbearman
Similarity score: 0.6935

tidygeocoder: An R package for geocoding
Submitting author: @jessecambon
Handling editor: @elbeejay (Active)
Reviewers: @cole-brokamp, @tsamsonov
Similarity score: 0.6924

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Aug 28, 2024

Related rOpenSci review here: ropensci/software-review#633

@arfon
Copy link
Member

arfon commented Aug 28, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @arfon is now the editor

@arfon
Copy link
Member

arfon commented Aug 28, 2024

@editorialbot add @jonthegeek as reviewer

@editorialbot
Copy link
Collaborator Author

@jonthegeek added to the reviewers list!

@arfon
Copy link
Member

arfon commented Aug 28, 2024

@editorialbot add @ccamara as reviewer

@editorialbot
Copy link
Collaborator Author

@ccamara added to the reviewers list!

@arfon
Copy link
Member

arfon commented Aug 28, 2024

👋 @jonthegeek, @ccamara – there's no additional review work to do here, rather, we're crediting you for your efforts on the earlier rOpenSci review: ropensci/software-review#633

@arfon
Copy link
Member

arfon commented Aug 28, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants