Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: IndeterminateBeam: A Python package for solving 1D indeterminate beams #2930

Closed
whedon opened this issue Dec 26, 2020 · 17 comments

Comments

@whedon
Copy link

whedon commented Dec 26, 2020

Submitting author: @JesseBonanno (Jesse Bonanno)
Repository: https://github.com/JesseBonanno/IndeterminateBeam
Version: v1.1.0
Editor: Pending
Reviewer: Pending
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @JesseBonanno. Currently, there isn't an JOSS editor assigned to your paper.

@JesseBonanno if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Dec 26, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Dec 26, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.12 s (222.0 files/s, 28392.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           9            340            658            795
Markdown                         3             80              0            200
reStructuredText                 6            129             83            147
TeX                              2             14              2            138
Jupyter Notebook                 3              0            548            122
DOS Batch                        1              8              1             26
JSON                             1              0              0             14
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            26            575           1299           1451
-------------------------------------------------------------------------------


Statistical information for the repository 'b8d37468bdbf7eff7cfdfc9d' was
gathered on 2020/12/26.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
JesseBonanno                    31         37978          36185          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
JesseBonanno               1793            4.7          0.2               10.43

@whedon
Copy link
Author

whedon commented Dec 26, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/jose.00065 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.7717/peerj-cs.103 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Dec 26, 2020

PDF failed to compile for issue #2930 with the following error:

/app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:147:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:89:in initialize'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in new' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in set_paper'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:58:in prepare' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:131:in <top (required)>'
from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in

'

@danielskatz
Copy link

👋 @JesseBonanno - I'm unsure if this fits JOSS, so the editors will now discuss if it meets JOSS's scope for review, specifically to make sure that we consider it research software (and also possible to check the size/scholarly effort of the software). This normally would take about a week, but might take longer due to the holidays.

Also, I notice that your paper does not compile due to an error in the affiliations, specifically that you didn't list one for you. Please add an affiliation, following the example in our sample, and then add a comment here starting with @whedon generate pdf to regenerate the PDF.

@danielskatz
Copy link

@whedon query scope

@whedon whedon added the query-scope Submissions of uncertain scope for JOSS label Dec 26, 2020
@whedon
Copy link
Author

whedon commented Dec 26, 2020

Submission flagged for editorial review.

@JesseBonanno
Copy link

Hi @danielskatz - I agree that it appeared to be fairly weak when considering the scope. I mainly have submitted this with consideration that it was a significant improvement to a previous published article (in fact that is how I found out about JOSS).

Okay, I didn't get the affiliation error when I used the Whedon paper preview service. Just letting you know in case this is something you would like to flag on your end.

I don't actually have any affiliations and have done this independently to help with creating higher order structural engineering python projects. I will add a blank affiliations section and hopefully that effectively resolves the issue, and is also okay by the JOSS criteria.

@JesseBonanno
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Dec 26, 2020

PDF failed to compile for issue #2930 with the following error:

/app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:213:in parse_affiliations': undefined method each' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:199:in parse_authors' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:93:in initialize'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in new' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in set_paper'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:58:in prepare' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:131:in <top (required)>'
from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in

'

@JesseBonanno
Copy link

@danielskatz - I am going to add a dummy affiliation in named "None" as suggested in this issue thread.

@JesseBonanno
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Dec 27, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Jan 4, 2021

@JesseBonanno - many thanks for your submission to JOSS. After a review by our editorial team, this submission has been determined as out of scope for JOSS.

I agree that it appeared to be fairly weak when considering the scope. I mainly have submitted this with consideration that it was a significant improvement to a previous published article (in fact that is how I found out about JOSS).

Please note, your earlier comment (and link) was to a JOSE paper, and we believe this submission may be better suited for that journal too.

@arfon
Copy link
Member

arfon commented Jan 4, 2021

@whedon reject

@whedon
Copy link
Author

whedon commented Jan 4, 2021

Paper rejected.

@whedon whedon added the rejected label Jan 4, 2021
@whedon whedon closed this as completed Jan 4, 2021
@JesseBonanno
Copy link

@arfon My mistake, thank you for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants