Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSE reviewers checklist: repository version #8

Open
atrisovic opened this issue Oct 21, 2020 · 1 comment
Open

JOSE reviewers checklist: repository version #8

atrisovic opened this issue Oct 21, 2020 · 1 comment

Comments

@atrisovic
Copy link
Member

Hi there,

I noticed that reviewers are asked to check if the repository with the content for JOSE is released as a particular versioning number:

Version: Does the release version given match the GitHub release (1.0-1)?

However, in practice, the submitting author may create another release during or after the review, making this statement untrue and confusing for the reviewer. Also, the software does not recognize if there was no prior tagged release of the repository.

A good alternative that could solve these problems could be:

Version: Is there a recent tagged release on GitHub that captures the presented educational content?

I hope this makes sense, but I'm also happy to follow up.

Thank you,
Ana

@arfon arfon transferred this issue from openjournals/whedon May 29, 2021
@labarba
Copy link
Member

labarba commented Oct 21, 2022

hi @atrisovic – sincere apologies, but it turns out I wasn't "watching" this repository and have not come poking here in a long time (I had it set to "only when @-mentioned"... I changed it now).

Your comment makes sense: this item of the checklist has often confused reviewers. We do ask for a tagged release at the end of the review process, which then is updated with the command @whedon set v.x.x. as version. We will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants