Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display of images or videos on questions page #245

Open
davidmooreppf opened this issue Jan 7, 2014 · 11 comments
Open

display of images or videos on questions page #245

davidmooreppf opened this issue Jan 7, 2014 · 11 comments
Assignees
@walter
Labels
design

Comments

@davidmooreppf
Copy link
Member

If a user includes an image in her question, will it appear on q detail page below "full q" body?

Doesn't nec. need to appear on q listing pages for launch. @walter I know you were working on this last week.
@ghost ghost assigned acacheung Jan 7, 2014
@walter
Copy link
Contributor

walter commented Jan 8, 2014

@davidmooreppf if there is an image or video, uploaded or through a submitted URL, it will show show up.

However, it could use styling by @acacheung.

@walter
Copy link
Contributor

walter commented Jan 8, 2014

One caveat is that they are through a CDN, so in development mode they show up as missing images.

@acacheung for your work, just drop the cdn_ from the image_tag or video_tag temporarily and then return it before you commit and push your changes.

acacheung added a commit that referenced this issue Jan 9, 2014
@acacheung
style media for questions page #245
ce52dc5
@ghost ghost assigned walter Jan 13, 2014
@davidmooreppf
Copy link
Member Author

Back to Walter - does this need a deploy? Perhaps. Tested just now on preview and got error msg. below ::

Media Failed to thumbnail with ffmpegthumbnailer. Check ffmpegthumbnailer install and verify video is not corrupt. Original error: No such file or directory - ffmpegthumbnailer -i /u/apps/askthem/releases/20140109234925/tmp/uploads/1389645475-7877-8112/thumb_Wall_of_Brauny.png -o /u/apps/askthem/releases/20140109234925/tmp/uploads/1389645475-7877-8112/tmpfile.png -c png -q 10 -s 192 -f

@walter
Copy link
Contributor

walter commented Jan 13, 2014

Yeah, I've received that too. There is something different in production that is inhibiting the creation of the thumbnail for the video. I'll have to debug it.

Will keep you posted.

@davidmooreppf
Copy link
Member Author

Just noting this still needs a debug. If we can't figure it out, we can comment it out for now on Q form. But keeping it in is great if we can fix it.

Media Failed to thumbnail with ffmpegthumbnailer. Check ffmpegthumbnailer install and verify video is not corrupt. Original error: No such file or directory - ffmpegthumbnailer -i /u/apps/askthem/releases/20140122213339/tmp/uploads/1390429681-22163-4387/thumb_Poker_Dogz.png -o /u/apps/askthem/releases/20140122213339/tmp/uploads/1390429681-22163-4387/tmpfile.png -c png -q 10 -s 192 -f

@walter
Copy link
Contributor

walter commented Jan 22, 2014

On my list.

It actually is pretty high priority as it may involve @rchekaluk doing some behind-the-scenes tweaking of the ffmpegthumbnailer. Will take a look tonight or tomorrow.

walter added a commit that referenced this issue Jan 25, 2014
@walter
Make is_video? case insensitive
4e0350c 
Supports #245
walter added a commit that referenced this issue Jan 25, 2014
@walter
Disable broken media thumbnailing
a112582 
Supports #245
walter added a commit that referenced this issue Jan 25, 2014
@walter
Use normal img/video tags in development
e41f1db 
Supports #245
walter added a commit that referenced this issue Jan 25, 2014
@walter
Add workaround for cloudfront issues w/ img/vid
a248883 
Supports #245
walter added a commit that referenced this issue Jan 25, 2014
@walter
Adjust test to handle disabled cdn
6ef74d4 
Supports #245
@walter walter mentioned this issue Jan 25, 2014
Open
@walter
Copy link
Contributor

walter commented Jan 25, 2014

This is in place and working on preview. It's deployed to production.

@davidmooreppf all that remains is testing with a real question on production. I would hold off on that until the staff member "delete question" functionality is in place.

@walter
Copy link
Contributor

walter commented Jan 26, 2014

@davidmooreppf, delete question is implemented in #266. Will need to repeat registering of staff members on production, then let me know, I'll grant staff member status, then you can delete questions on both preview and production.

Waiting on some ops stuff for @rchekaluk (sidekiq restart not working).

@walter
Copy link
Contributor

walter commented Jan 27, 2014

@davidmooreppf & @maryamgunja you can test this now on the live site.

Once done, delete the question.

@walter
Copy link
Contributor

walter commented Feb 4, 2014

@davidmooreppf ^

@walter walter mentioned this issue Feb 9, 2014
Closed
@walter
Copy link
Contributor

walter commented Feb 9, 2014

See #333 about issue with showing Vimeo videos. @davidmooreppf please use this issue for a discussion of that problem and further QA of this feature.

walter added a commit that referenced this issue Feb 9, 2014
@walter
Fix accessible url check
8af6bd4 
'vidibus-validate_uri' gem can't handle relative URLs.

Supports #245
walter added a commit that referenced this issue Feb 9, 2014
@walter
Only prompt for photos, further video improvements
56c56dc 
Supports #245
walter added a commit that referenced this issue Feb 10, 2014
@walter
Limiting prompt for uploads to photo only
a2fb4f6 
Supports #245
@walter walter mentioned this issue Feb 27, 2014
Closed
walter added a commit that referenced this issue Feb 27, 2014
@walter
Add auto_html to question & answer attributes
bc97444 
Fixes issues w/ question.media_file_url embedding.

Closes #381
Supports #245
walter added a commit that referenced this issue Feb 27, 2014
@walter
Add tooltip for hashtags & links for question.body
82ab47a 
Supports #381
Supports #245
walter added a commit that referenced this issue Feb 27, 2014
@walter
show both media & media_file_url
d5a0fa8 
Supports #381
Supports #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walter walter

Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@walter @davidmooreppf @acacheung