Turn honor_timestamps off for resource scrape config #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics for pods were included in queries for some period after the pod was already removed. This resulted in inaccurate values for autoscaling. Turning honor_timestamps off for the kubernetes-resource-metrics job seems to fix this issue. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metrics for pods were included in PromQL queries for some period after the pod was already removed. This resulted in inaccurate values for autoscaling.
Turning
honor_timestampsoff for the kubernetes-resource-metrics scrape job seems to fix this issue.Why is this needed?
Improve accuracy of autoscaling queries.
Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
This has been discovered and tested by @alexellis in his cluster and reproduced in my cluster.
Types of changes
Checklist:
git commit -s