Fix typo in target label for openfaas-function-pods job #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
alexellis
added a commit
that referenced
this pull request
Aug 22, 2024
There was a typo, which was fixed in #1222 when emiting the label for the namespace of a Pod which is required for custom scaling, a new feature. This change is only required if you wish to test custom scaling with metrics scraped directly from the function Pod. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a typo in the
kubernetes_namespacetarget label for the openfaas-function-pods job.Why is this needed?
Fixes an issue where the namespace was missing in the
function_namelabel which made it impossible to use custom metrics from function pods in autoscaling recording rules.Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
Types of changes
Checklist:
git commit -s