Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting the deployment strategy in Profiles #1215

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

welteki
Copy link
Member

@welteki welteki commented Jun 7, 2024

Description

Update types, clientset and CRDs to support setting the deployment strategy for functions using Profiles.

Why is this needed?

  • I have raised an issue to propose this change (required)

Support for changing the deployment strategy type is required to update functions using GPUs in a cluster with limited GPU availability.

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

New types where used in the pro fork of faas-netes where the support for Profiles is implemented.

Changes for the OpenFaaS chart were verified while testing this feature with faas-netes pro.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

welteki added 3 commits June 7, 2024 12:02
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 2aa53c7 into openfaas:master Jun 11, 2024
3 checks passed
@welteki welteki deleted the deployment-strategy branch June 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants