Skip to content

Commit

Permalink
Rename brokerHost to brokerHosts for Kafka connector
Browse files Browse the repository at this point in the history
The newest version of the Kafka connector will support multiple
bootstrap servers as a comma-separated list via the brokerHosts
variable, this is a breaking change from previously being
brokerHost, and only supporting a single host.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
  • Loading branch information
alexellis committed Sep 19, 2023
1 parent dcab656 commit d72d6a5
Show file tree
Hide file tree
Showing 7 changed files with 35 additions and 25 deletions.
4 changes: 2 additions & 2 deletions chart/kafka-connector/templates/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ spec:
- name: secret_mount_path
value: "/var/secrets"
{{- end }}
- name: broker_host
value: {{ .Values.brokerHost | quote }}
- name: broker_hosts
value: {{ .Values.brokerHosts | quote }}
{{- if .Values.upstreamTimeout }}
- name: upstream_timeout
value: {{ .Values.upstreamTimeout | quote }}
Expand Down
30 changes: 17 additions & 13 deletions chart/kafka-connector/values.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
# The Kafka connector is an OpenFaaS Pro feature
#
# Purchase a license at https://openfaas.com/support/
# This component is licensed for OpenFaaS Standard/Enterprise customers only.
# Purchase or obtain a trial license at https://openfaas.com/pricing/

# You will need to create a license named "openfaas-license" - see the
# chart README for detailed instructions.


# Set either a single topic, or multiple with a comma separating each
# topics: payment.requested
# topics: "payment.requested,customer.created,invoice.generated"
topics: faas-request

# The address of the Kafka broker, if multiple are available, include
# them as a comma separated list i.e. "kafka-1:9092,kafka-2:9092,kafka-3:9092"
brokerHosts: kf-kafka:9092

image: ghcr.io/openfaasltd/kafka-connector:0.7.3

# Output detailed logs from the consumer group's lifecycle
sessionLogging: true

# The number of replicas of the connector should usually match the size of the
# partition exactly. So for a topic with 6 partitions, set the replicas to 6.
# This number must not be higher, but can be lower, to save on resources.
replicas: 1

# Max timeout for a function
Expand All @@ -21,14 +33,6 @@ rebuildInterval: 30s
# Use with slow consumers or long running functions
asyncInvocation: false

# Set either a single topic, or multiple with a comma separating each
# topics: payment.requested
# topics: payment.requested,customer.created,invoice.generated
topics: faas-request

# Your Kafka broker
brokerHost: kf-kafka:9092

# 1MB = 1024 bytes * 1024
maxBytes: "1048576"

Expand Down Expand Up @@ -85,8 +89,8 @@ resources:
# limits:
# memory: "256Mi"

# Encryption
tls: false
# Use TLS Encryption, this is usually set to true.
tls: true

# Authentication

Expand Down
5 changes: 2 additions & 3 deletions chart/postgres-connector/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# The Postgres connector is an OpenFaaS Pro feature
#
# Purchase a license at https://openfaas.com/support/
# This component is licensed for OpenFaaS Standard/Enterprise customers only.
# Purchase or obtain a trial license at https://openfaas.com/pricing/

# You will need to create a license named "openfaas-license" - see the
# chart README for detailed instructions.
Expand Down
5 changes: 4 additions & 1 deletion chart/pro-builder/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# You will need to create a license named "openfaas-license" - see the
# This component is licensed for OpenFaaS Standard/Enterprise customers only.
# Purchase or obtain a trial license at https://openfaas.com/pricing/

# You will need to create a license named "openfaas-license" - see the
# chart README for detailed instructions.

# image is for the pro-builder API
Expand Down
6 changes: 6 additions & 0 deletions chart/queue-worker/values.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# This component is licensed for OpenFaaS Standard/Enterprise customers only.
# Purchase or obtain a trial license at https://openfaas.com/pricing/

# You will need to create a license named "openfaas-license" - see the
# chart README for detailed instructions.

image: ghcr.io/openfaasltd/jetstream-queue-worker:0.3.13

replicas: 1
Expand Down
5 changes: 2 additions & 3 deletions chart/sns-connector/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# The Kafka connector is an OpenFaaS Pro feature
#
# Purchase a license at https://openfaas.com/support/
# This component is licensed for OpenFaaS Standard/Enterprise customers only.
# Purchase or obtain a trial license at https://openfaas.com/pricing/

# You will need to create a license named "openfaas-license" - see the
# chart README for detailed instructions.
Expand Down
5 changes: 2 additions & 3 deletions chart/sqs-connector/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# The Kafka connector is an OpenFaaS Pro feature
#
# Purchase a license at https://openfaas.com/support/
# This component is licensed for OpenFaaS Standard/Enterprise customers only.
# Purchase or obtain a trial license at https://openfaas.com/pricing/

# You will need to create a license named "openfaas-license" - see the
# chart README for detailed instructions.
Expand Down

0 comments on commit d72d6a5

Please sign in to comment.