Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Convert @parity/api to TypeScript #21

Open
amaury1093 opened this issue Oct 16, 2018 · 5 comments
Open

Convert @parity/api to TypeScript #21

amaury1093 opened this issue Oct 16, 2018 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@amaury1093
Copy link
Collaborator

It's the last package still in plain JS.

@amaury1093
Copy link
Collaborator Author

amaury1093 commented Jan 2, 2019

@yjkimjunior nice I just saw you assigned yourself, are you working on this?

Note: the way it's done right now, we can convert api to TS incrementally. See for example https://github.com/paritytech/js-libs/tree/42743c94a8c03c07f89ba0157874cc891e218cb3/packages/api/src, only util/ is in TS now. So feel free to tackle this bit by bit.

@pmespresso
Copy link
Contributor

Had this on the backburner but working on it now. I'm starting by renaming files to .ts then seeing what breaks and then adding type definitions from there. Starting with building a interface for Contracts

@JamesLefrere
Copy link
Contributor

@yjkimjunior Would you mind if I took this? Just my kind of thing :)

After this, it might also be interesting to explore adding a TypeChain target https://github.com/ethereum-ts/TypeChain

@pmespresso
Copy link
Contributor

hey @JamesLefrere please go ahead, forgot to unassign myself

@ksato9700
Copy link
Contributor

@JamesLefrere
Do you mind if I take the conversion of some components?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants