-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate: answer to question "can observations be made public" into preprocessors and release text #295
Comments
There are two avenues here, each with its own set of logical steps: Using DP Count:
Using User Estimation:
Thanks to @Shoeboxam for the discussion |
Needed for computing DP counts:
|
@raprasad Why don't we approach this incrementally, and first build a feature where the user has to answer yes. This way, we can first develop the part of the code that takes the estimate from the front end and passes it into the process. Once this is merged, we can add functionality for the case where they say "no". |
Another option is to create 2 analysis objects, one for the dp count and one for the rest, and split the budget between them. This way we could reuse the existing ValidateReleaseUtil class to compute what we need, rather than creating new classes to compute the dp count separately. The workflow could look like this:
|
See google doc: https://docs.google.com/document/d/1xUihcjh4zmfnhG0-2EC-uG-qzpde8WXphRksB0NvHe8/edit#
(Redo steps below after doc discussion)
2. update the StatSpec class (stat_spec.py) to include a variable indicatingis_dataset_size_public
3. ^ update the computation chains for existing stats appropriately.e.g. if theis_dataset_size_public == True
, update the chain, use a different chain, etc.include tests for each stat. (Check taht if the dataset size is private then more epsilon is used, etc.4. Integrate into larger workflow. e.g.ValidateReleaseUtil.build_stat_specs()
ValidateReleaseUtil.__init__
: add self.is_dataset_size_public = NoneValidateReleaseUtil.run_preliminary_steps
: set self.is_dataset_size_public to True or FalseAdd functionDatasetInfo.is_dataset_size_public()
similar toget_dataset_size()
except finds answer to the dataset question withinDepositorSetupInfo
ValidateReleaseUtil.build_stat_specs()
, userself.is_dataset_size_public
when building the StatSpec objectsThe text was updated successfully, but these errors were encountered: