Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient user input validation in library #897

Open
serverhorror opened this issue Apr 21, 2022 · 1 comment
Open

Insufficient user input validation in library #897

serverhorror opened this issue Apr 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@serverhorror
Copy link
Contributor

When using the backslash character (\) in your git username that user input is not properly validated and leads to broken builds

This comes up when users are using their "qualified" Windows login name as their git author info, e.g.: FABRIKAM\\alice ([email protected])

To Reproduce
Steps to reproduce the behavior:

  1. Set your git username to domain\\user
  2. commit
  3. push
  4. Jenkins build fails

Expected behavior

The Jenkins build should successfully continue. The username is only a string that should not cause the build to fail

Screenshots
If applicable, add screenshots to help explain your problem.

Affected version (please complete the following information):

  • OpenShift: ??
  • OpenDevStack 4.x
@serverhorror serverhorror added the bug Something isn't working label Apr 21, 2022
@KMax
Copy link

KMax commented Apr 21, 2022

@serverhorror We had the issue in Openshift 3.x and OpenDevStack 4.x. I think your description of the issue is complete, I have nothing to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants