Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce hunting date nesting? #36

Closed
waldoj opened this issue Jun 20, 2014 · 1 comment
Closed

Reduce hunting date nesting? #36

waldoj opened this issue Jun 20, 2014 · 1 comment
Labels

Comments

@waldoj
Copy link
Member

waldoj commented Jun 20, 2014

This seems way over-nested:

"seasons": {
    "season": {
        "method": "firearm",
        "range": {
            "statewide": {
                "season": {
                    "date": {
                        "starts": "2013-07-01",
                        "ends": "2014-06-30"
                    }
                }
            }
        }
    }

Shouldn't date be up a couple of levels, as a child of range? Isn't seasonsseason → [...] → season overspecified?

@waldoj
Copy link
Member Author

waldoj commented Jun 30, 2014

The idea here is to group together time-bound elements. In addition to date ranges, there can be days (e.g., crows: "days": ["Monday", "Wednesday", "Friday", "Saturday"]), or times. Realistically, the best that we can do is eliminate the season container (in the above example, it's a child of statewide).

But, really, this example looks pretty different now, in light of #34. At the moment, it looks like this:

"seasons": {
    "season": {
        "method": "firearm",
        "range": {
            "1": {
                "places": {
                    "Virginia": {
                        "gnis_id": "TK",
                        "fips_code": "TK"
                    }
                },
                "season": {
                    "date": {
                        "starts": "2013-07-01",
                        "ends": "2014-06-30"
                    }
                }
            }
        }
    }
}

I think it's a good idea to break up the range data into place restrictions and time restrictions, and I think that season is probably the most sensible terminology to use there. While I think this looks overspecified for simple species (e.g., possum), I think it's appropriate for bear, deer, etc.

I'm going to close this without making any changes.

@waldoj waldoj closed this as completed Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant