-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create records for all species of fish #19
Comments
Looking forward to more fish info - we at DEQ are building it into our team's Datathon app: https://github.com/tonygambone/va-waterways-map |
Integrate @tonygambone’s additions, after inspecting each one and making corrections where necessary. Per #19.
@tonygambone Wow. So, that happened. I just went to add the missing herring, only to discover that of course you omitted herring because herring. That commit message should have read "Integrate all remaining fish species." |
Wow, you've been busy! Looking good. I'd also like to get fish images populated - do you have a source for those? Don't know if you heard but we won the Judge's Choice award with our app. I'm hoping we can keep working on it and improving it - this fish data would be a big step forward. |
Oh, right—I forgot that images are part of this ticket. :-/ The fish images are all on DGIF's site. The image URL contains the fish ID, which is included in the URL on that list, so I think I'll just grab the page source, regex 'em out, and manually paste them into each record. That should only take 5–10 minutes. Congratulations on your win! If fish data is particularly important to y'all now, then I'm happy to continue to prioritize it over hunting data. |
Thanks! I think with images, and maybe limits, we'll have everything we might need for a while. I appreciate your help! |
Images! I think that resolves this issue. Now onto #29. |
Use the fish ID guide as the reference. Start with the raw data from DGIF. That means:
The text was updated successfully, but these errors were encountered: