Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create records for all species of fish #19

Closed
35 of 39 tasks
waldoj opened this issue May 28, 2014 · 6 comments
Closed
35 of 39 tasks

Create records for all species of fish #19

waldoj opened this issue May 28, 2014 · 6 comments

Comments

@waldoj
Copy link
Member

waldoj commented May 28, 2014

Use the fish ID guide as the reference. Start with the raw data from DGIF. That means:

  • largemouth bass
  • smallmouth bass
  • spotted bass
  • black crappie
  • white crappie
  • bluegill
  • redear sunfish
  • redbreast sunfish
  • pumpkinseed
  • green sunfish
  • rock bass
  • roanoke bass
  • flier
  • warmouth
  • white bass
  • striped bass
  • hybrid striped bass
  • white perch
  • walleye
  • yellow perch
  • sauger
  • northern pike
  • chain pickerel
  • muskellunge
  • rainbow trout
  • brown trout
  • brook trout
  • flathead catfish
  • blue catfish
  • channel catfish
  • white catfish
  • American shad
  • hickory shad
  • longnose gar
  • blueback herring
  • alewife
  • bowfin
  • common carp
  • freshwater drum
@tonygambone
Copy link
Contributor

Looking forward to more fish info - we at DEQ are building it into our team's Datathon app: https://github.com/tonygambone/va-waterways-map

@waldoj waldoj added the fishing label Sep 5, 2014
waldoj added a commit that referenced this issue Sep 5, 2014
Integrate @tonygambone’s additions, after inspecting each one and
making corrections where necessary. Per #19.
waldoj added a commit that referenced this issue Sep 5, 2014
@waldoj
Copy link
Member Author

waldoj commented Sep 5, 2014

@tonygambone Wow. So, that happened. I just went to add the missing herring, only to discover that of course you omitted herring because herring. That commit message should have read "Integrate all remaining fish species."

@waldoj waldoj closed this as completed Sep 5, 2014
@tonygambone
Copy link
Contributor

Wow, you've been busy! Looking good. I'd also like to get fish images populated - do you have a source for those?

Don't know if you heard but we won the Judge's Choice award with our app. I'm hoping we can keep working on it and improving it - this fish data would be a big step forward.

@waldoj waldoj reopened this Sep 6, 2014
@waldoj
Copy link
Member Author

waldoj commented Sep 6, 2014

Oh, right—I forgot that images are part of this ticket. :-/ The fish images are all on DGIF's site. The image URL contains the fish ID, which is included in the URL on that list, so I think I'll just grab the page source, regex 'em out, and manually paste them into each record. That should only take 5–10 minutes.

Congratulations on your win! If fish data is particularly important to y'all now, then I'm happy to continue to prioritize it over hunting data.

@tonygambone
Copy link
Contributor

Thanks! I think with images, and maybe limits, we'll have everything we might need for a while. I appreciate your help!

waldoj added a commit that referenced this issue Sep 8, 2014
@waldoj
Copy link
Member Author

waldoj commented Sep 8, 2014

Images! I think that resolves this issue. Now onto #29.

@waldoj waldoj closed this as completed Sep 8, 2014
waldoj added a commit that referenced this issue Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants