Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE and LICENSE.doc causes go-license-detector to see only evidence of CC-BY-SA-4.0 #68

Open
thediveo opened this issue Oct 5, 2021 · 6 comments

Comments

@thediveo
Copy link

thediveo commented Oct 5, 2021

When scanning Go module dependencies to create BOMs with tools like cyclonedx-gomod the setup of this repository/Go module with both LICENSE and LICENSE.doc causes the go-license-detector to see only evidence of CC-BY-SA-4.0. go-license-detector does not detect the presence of the Apache-2.0 license in LICENSE, or this evidence gets thrown under the bus in the process of creating the BOM by tools using go-license-detector.

Would it be possible to clean up the LICENSE and LICENSE.doc files with preferably only a single LICENSE file that tools like go-license-detector can correctly handle?

@vbatts
Copy link
Member

vbatts commented Oct 5, 2021

interesting. It is a common pattern for projects that carry multiple licenses for all their components. Even if we fix for this project, that is a bug in the scanner and should be fixed there.

@thediveo
Copy link
Author

thediveo commented Oct 5, 2021

What I've seen so far in other projects are declarations like (BSD-3-Clause OR GPL-2.0) or (MIT AND BSD-3-Clause) in their single license. For instance, https://github.com/crypto-browserify/sha.js/blob/master/LICENSE contains both licenses in a single LICENSE file; here, go-license-detector identifies the LICENSE contents as "(MIT AND BSD-3-Clause)".

@caniszczyk
Copy link
Contributor

caniszczyk commented Oct 5, 2021 via email

@thediveo
Copy link
Author

thediveo commented Oct 5, 2021

Ah, good to know!

@thediveo
Copy link
Author

thediveo commented Oct 5, 2021

A look into go-license-detector reveals that it scans (beyond others) files named "license" with certain extensions, but not .doc. So Im closing this issue and file an issue with the detector project. Thank you for your help!

@thediveo
Copy link
Author

thediveo commented Oct 5, 2021

Is there a reason for using a .docs extension instead of .doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants