Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination on leaflet list does not preserve filters (EL-228) #242

Open
oajirabot opened this issue Dec 29, 2013 · 0 comments
Open

Pagination on leaflet list does not preserve filters (EL-228) #242

oajirabot opened this issue Dec 29, 2013 · 0 comments

Comments

@oajirabot
Copy link

When browsing leaflets and a filter is selected (for example, showing only leaflets for a particular party), and the pagination function at the bottom of the list is used, it does not preserve the filter state.

As a result, clicking on the link for "Page 2" instead of taking you to the second page of the filtered list, takes you to the second page on the list of all leaflets, unfiltered.

In templates/leaflets.tpl:46, the offending code is present. It needs to be changed so that the filter state is placed into the links.

Additionally, there is a bug on line 45 of the same file, where if the current page is selected, the outputted <li> element is instead <liclass="current">, with no space between li and class.


Issue details imported from Jira:

Detail Value
Assignee Unassigned
Reporter Michael Farrell
Created 2013-09-12 00:10:54
Updated 2013-09-12 22:29:04

Imported Jira Comments

Henare Degan - 2013-09-12 22:29:04

Thanks for reporting these issues Michael.

FYI I've upgraded your permissions on the issue tracker so you can change tickets now too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant