Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce IdentifierFactory cloned from unreleased dhp-commons after dhp-schemas dependency upgrade #1454

Closed
marekhorst opened this issue Apr 23, 2024 · 1 comment
Closed

Introduce IdentifierFactory cloned from unreleased dhp-commons after dhp-schemas dependency upgrade #1454

marekhorst opened this issue Apr 23, 2024 · 1 comment
Assignees
@marekhorst

Comments

@marekhorst
Copy link
Member

marekhorst commented Apr 23, 2024 •
edited
Loading

After introducing #1453 change PatentExporterJob and SoftwareExporterJob cannot be compiled due to missing eu.dnetlib.dhp.schema.oaf.utils.IdentifierFactory.IdentifierFactory class which was moved and become part of the different dhp-commons module which wasn't released yet.

This means in order to unblock the ongoing provisioning round we need to incorporate this class (along with all the dependant classes) in the IIS codebase until the updated version of dhp-commons release. Once it gets released we should drop the duplicated code (addressed by #1455).
@marekhorst marekhorst self-assigned this Apr 23, 2024
@marekhorst marekhorst mentioned this issue Apr 23, 2024
Open
marekhorst added a commit that referenced this issue Apr 23, 2024
@marekhorst
Closes #1453, #1454: Upgrade the dhp-schemas dependency version and i…
23245fb 
…ntroduce IdentifierFactory cloned from unreleased dhp-commons

This commit addresses two changes:
* upgrade the dhp-schemas dependency version range from [4.0.0, 5.0.0) to [6.0.0, 7.0.0)
* introduce IdentifierFactory cloned from unreleased dhp-commons after dhp-schemas dependency upgrade
@marekhorst
Copy link
Member Author

Closed with this commit: 23245fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marekhorst marekhorst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marekhorst