Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "attribution name" #18

Open
nvkelso opened this issue Apr 3, 2017 · 2 comments
Open

Rename "attribution name" #18

nvkelso opened this issue Apr 3, 2017 · 2 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Apr 3, 2017

In sources like ch/basel-stadt.json:

We state that the source needs attribution, and provide the recommended credit text with a confusingly named property called "attribution name":

        "attribution": true,
        "attribution name": "Geodaten Kanton Basel-Stadt",

This config was originally added in #7.

I propose we renamed "attribution name" to something like "attribution-text" to remove the space and make it clearer that the this is the text the source requires (not just the proper name of the source). Because the recommended text is sometimes crazy long, doesn't fit in constrained layouts it's probably also useful to specify the source name in a clean way with something like source-name.

        "attribution": true,
        "attribution-text": "Geodaten Kanton Basel-Stadt",
        "source-name": "Kanton Basel-Stadt",

Referencing http://www.geo.bs.ch/geodaten/nutzungsbedingungen.html where they indicate the required CC-BY attribution text is Geodaten Kanton Basel-Stadt.

Sources with the older "attribution name" syntax should be upgraded either with this issue or with a followup issue in openaddresses/openaddresses.

There are also cases where attribution (required) might be legally false, but we'd still fill in "attribution-text" &/or "source-name" as a curtesy.

@nvkelso
Copy link
Member Author

nvkelso commented Apr 3, 2017

/cc @migurski

@migurski
Copy link
Member

migurski commented Apr 3, 2017

I like this proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants