Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't uppercase field names for CSV sources #61

Open
arch0345 opened this issue Sep 11, 2024 · 1 comment
Open

Don't uppercase field names for CSV sources #61

arch0345 opened this issue Sep 11, 2024 · 1 comment

Comments

@arch0345
Copy link

arch0345 commented Sep 11, 2024

Looks like we're getting bitten by a KeyError here again. Something in our pipeline is upper-casing CSV row names. Last time I looked at this I couldn't figure out where/why we're doing this. It involves a change to the batch-machine code, I think.

Originally posted by @iandees in openaddresses/openaddresses#7395 (comment)

cc @ingalls

@arch0345 arch0345 changed the title Looks like we're getting bitten by a KeyError here again. Something in our pipeline is upper-casing CSV row names. Last time I looked at this I couldn't figure out where/why we're doing this. It involves a change to the batch-machine code, I think. Don't uppercase field names for CSV sources Sep 11, 2024
@skylarmt
Copy link

skylarmt commented Nov 2, 2024

Something in our pipeline is upper-casing CSV row names.

Is it

source_x = source_row[lon_name.upper()]
as suggested by andrewharvey in openaddresses/openaddresses#5554?

Fixing a longstanding bug and closing three other issues and two pull requests can't be as easy as removing two little .upper() statements, can it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants