Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why use ROTATION_AVERAGING_L2 as default in global rotation computation #937

Closed
shuguohui opened this issue May 31, 2017 · 5 comments · May be fixed by #1636
Closed

why use ROTATION_AVERAGING_L2 as default in global rotation computation #937

shuguohui opened this issue May 31, 2017 · 5 comments · May be fixed by #1636
Labels

Comments

@shuguohui
Copy link

when the image count is large(more than 5000),i found that the global rotation computation use ROTATION_AVERAGING_L2 is very slow,but use ROTATION_AVERAGING_L1 is fast.
so my question is :why use ROTATION_AVERAGING_L2 as default in global rotation computation?is there some weaknesses for ROTATION_AVERAGING_L1?

@pmoulon
Copy link
Member

pmoulon commented Jun 1, 2017

Hi @shuguohui
It's simply because most of the time I observed that the ROTATION_AVERAGING_L2 method was giving me a better initial estimates for the rotation rather than the ROTATION_AVERAGING_L1 (I must admit that I still dislike that the L1 rotation averaging is starting for a MST). Ideally I would prefer having a global optimal minimization....

But since the rotation_averaging method is a command line parameter, feel free to choose the one that fit your needs.

On my side I prefer to consider that this problem "robust large scale rotation averaging" is not yet solved

@shuguohui
Copy link
Author

ROTATION_AVERAGING_L2 can speed up by MKL,(when not use MKL,the cpu use only 10%,and use MKL,the cpu use more than 50%),in 10000 images test,use MKL is speed up 3-4 times

@pmoulon
Copy link
Member

pmoulon commented Jun 1, 2017

Using a Sparse Eigen value computation could made the thing faster and less memory hungry. Spectra library -> https://github.com/yixuan/spectra

@pmoulon
Copy link
Member

pmoulon commented Nov 10, 2017

@shuguohui Any help to port the L2 code to use Spectra?

@pmoulon
Copy link
Member

pmoulon commented Jan 4, 2018

Closed due to inactivity.
@shuguohui Feel free to reopen if you are willing to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants