Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling missing in GroupDetails #1772

Open
PatelVatsalB21 opened this issue Feb 14, 2021 · 1 comment · May be fixed by #2050
Open

Error handling missing in GroupDetails #1772

PatelVatsalB21 opened this issue Feb 14, 2021 · 1 comment · May be fixed by #2050
Labels
enhancement good first issue

Comments

@PatelVatsalB21
Copy link
Contributor

Summary:
When user opens group details and something unexpected occurs like no internet connection, all fields are shown empty.

Steps to reproduce:
1 Open groups
2 Turn off Internet
3 Open any group

Expected behaviour:
Simple error layout should be visible.

Device and Android version:
Any

Recording:

20210214_224543.1.mp4
PatelVatsalB21 pushed a commit to PatelVatsalB21/android-client that referenced this issue Feb 14, 2021
fix openMF#1772: Error handling added to GroupDetailsFragment
1b44c45
@PatelVatsalB21 PatelVatsalB21 mentioned this issue Feb 14, 2021
Closed
3 tasks
@danishjamal104
Copy link
Collaborator

@PatelVatsalB21 I think it would be better to merge this issue with #1770 since both are similar. This way number of PRs will be less and it would be easy for maintainers while merging the PR.

PatelVatsalB21 pushed a commit to PatelVatsalB21/android-client that referenced this issue Feb 15, 2021
fix openMF#1770 & openMF#1772: Error handling added to Client & Group…
7ea8c45 
…DetailsFragment
@kmanikanta335 kmanikanta335 linked a pull request Nov 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
3 participants
@danishjamal104 @PatelVatsalB21 @Aditya-gupta99