Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sed changes in Dockerfiles #8

Open
josephmckinsey opened this issue Oct 4, 2023 · 1 comment
Open

Fix sed changes in Dockerfiles #8

josephmckinsey opened this issue Oct 4, 2023 · 1 comment

Comments

@josephmckinsey
Copy link
Contributor

This sed should probably be replaced with a different version of sgidal-example. I'm working on that now + some other things.

sed -i 's/pydantic/pydantic>=1.7,<2/g' requirements.txt && pip install -r requirements.txt

This sed is a bit trickier since this kind of parameter should never have been hard coded into the state estimator. Ideally, this should be read in through the input_mapping.json

sed -i "s/local_feeder/feeder/g" "/home/build/gridappsd-state-estimator/state-estimator/include/PlatformInterfaceGADAL.hpp" && \

@karthikbalasu
Copy link
Collaborator

karthikbalasu commented Oct 5, 2023

sed -i "s/local_feeder/feeder/g" "/home/build/gridappsd-state-estimator/state-estimator/include/PlatformInterfaceGADAL.hpp" && \
is due to https://github.com/GRIDAPPSD/gridappsd-state-estimator/blob/GADAL.0.6/state-estimator/include/PlatformInterfaceGADAL.hpp#L67 referring to https://github.com/openEDI/oedisi-example/blob/main/scenarios/docker_system.json#L40 as local_feeder instead of feeder. In order to fix this, an issue needs to be created at https://github.com/GRIDAPPSD/gridappsd-state-estimator. The sed here is a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants