-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aws id generator from core sdk #1489
Comments
how do we proceed with the removal from the core repo? Do we add a deprecated message/warning and release a version? |
#1560 You can copy some of the ideas from this PR. (That PR removes an entire crate, but this is just a functionality, so adjust wordings accordingly.) |
Deprecates the XrayIdGenerator in the opentelemetry core sdk. Now available in opentelemetry-aws Relates #1489
Would this be the right time to raise a PR where the XrayIdGenerator is removed from the core repo? Or do we wait for a few releases? |
Hey sorry I missed this message until now! It should be removed now : #1820 |
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/trace/id_generator/aws.rs must be moved to contrib crate and should not be part of core sdk.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#id-generators
The text was updated successfully, but these errors were encountered: