Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracer does weak->Arc upgrade twice in hot path leading to bottleneck #1801

Open
cijothomas opened this issue May 22, 2024 · 2 comments
Open

Tracer does weak->Arc upgrade twice in hot path leading to bottleneck #1801

cijothomas opened this issue May 22, 2024 · 2 comments
Assignees
@TommyCpp
Milestone
Tracing SDK Stable

Comments

@cijothomas
Copy link
Member

cijothomas commented May 22, 2024 •
edited

Tracer holds a weakref to its TracerProvider and attempts to upgrade that to an Arc twice in the hot path - one during span start and then again during span end. This is affecting throughput due to contention.

This issue is already fixed for Logs, opening a new issue to track fixing the same for traces.
@cijothomas cijothomas added this to the Tracing SDK Stable milestone May 22, 2024
@TommyCpp TommyCpp self-assigned this May 22, 2024
@TommyCpp
Copy link
Contributor

Will take a look this week

@TommyCpp TommyCpp mentioned this issue May 27, 2024
Merged
4 tasks
@TommyCpp
Copy link
Contributor

TommyCpp commented May 27, 2024 •
edited

  1. Make the span processor shutdown from any reference fix: make shutdown &self in span processor #1836
  2. Add shutdown to sdk tracer provider feat: add shutdown in TracerProvider #1855
  3. Remove global::shutdown_global_tracer_provider
  4. Now tracer provider can take a TracerProviderInner Arc pointer. feat: add shutdown in TracerProvider #1855

@TommyCpp TommyCpp mentioned this issue Jun 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TommyCpp TommyCpp

Labels
None yet
Projects
None yet
Milestone
Tracing SDK Stable
Development

No branches or pull requests
2 participants
@cijothomas @TommyCpp