We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appender's Visitor creates own vec! and pushes items into it. And then a new vec! is allocated inside LogRecord and the above is copied to it
Opening an issue to track avoiding this intermediate array. The EventVisitor can be given the LogRecord itself while newing up, so it can record attributes directly to LogRecord. Or alternatively, expose another API to accept a Vec! (taking ownership) - I tried this in https://github.com/open-telemetry/opentelemetry-rust/compare/main...cijothomas:cijothomas/logrecord-addattribute?expand=1, which boosts stress test from ~27M/sec to ~34M/sec, and improves bencmark for ot_layer_enabled from 560ns to 450ns.
EventVisitor
LogRecord
The text was updated successfully, but these errors were encountered:
lalitb
Successfully merging a pull request may close this issue.
Appender's Visitor creates own vec! and pushes items into it.
And then a new vec! is allocated inside LogRecord and the above is copied to it
Opening an issue to track avoiding this intermediate array. The
EventVisitorcan be given theLogRecorditself while newing up, so it can record attributes directly toLogRecord. Or alternatively, expose another API to accept a Vec! (taking ownership) - I tried this in https://github.com/open-telemetry/opentelemetry-rust/compare/main...cijothomas:cijothomas/logrecord-addattribute?expand=1, which boosts stress test from ~27M/sec to ~34M/sec, and improves bencmark for ot_layer_enabled from 560ns to 450ns.The text was updated successfully, but these errors were encountered: