Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics instrumentation sqlite3 #1147

Open
Tracked by #1040
srikanthccv opened this issue Jun 21, 2022 · 6 comments
Open
Tracked by #1040

Metrics instrumentation sqlite3 #1147

srikanthccv opened this issue Jun 21, 2022 · 6 comments

Comments

@srikanthccv
Copy link
Member

DB semconv : https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/database-metrics.md

@artemrys
Copy link
Contributor

I would like to help with this one, I am a newbie in the open-telemetry world, but I see you marked this one as "good first issue", so can you please assign this one to me?

@srikanthccv srikanthccv removed the help wanted Extra attention is needed label Jun 25, 2022
@srikanthccv
Copy link
Member Author

Thanks. Feel free to ask any questions here or on our slack channel.

@artemrys
Copy link
Contributor

Moving here a conversation from Slack:

It seems that there is no work that needs to be done in sqlite3 package specifically, as there is no signs of useful attributes for sqlite3 connection object that could be extracted according to DB semconv.

@srikanthccv said

If there are no attributes that's fine but instrumentation should still be done just like how tracing instrumentation done. Looks like all the work is done in dbapi instrumentation package. You can work on that package.

@srikanthccv do you know is there any example that already implements something similar?

@lzchen
Copy link
Contributor

lzchen commented Jun 28, 2022

@artemrys

do you know is there any example that already implements something similar?

I do not believe metrics have been implemented for any db instrumentations in Python.

@Annosha
Copy link

Annosha commented Oct 11, 2024

@lzchen @srikanthccv is this issue still up-for the grab? If so I'd like to work on it.

@lzchen
Copy link
Contributor

lzchen commented Nov 4, 2024

@Annosha

This is another semantic convention migration issue due to this so probably not a good first issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants