Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReadWriteLogRecord accessors #6895

Open
jack-berg opened this issue Nov 19, 2024 · 0 comments
Open

Add ReadWriteLogRecord accessors #6895

jack-berg opened this issue Nov 19, 2024 · 0 comments
Labels
Feature Request Suggest an idea for this project

Comments

@jack-berg
Copy link
Member

Currently, ReadWriteLogRecord forces you to make an immutable copy of the data (by calling toLogRecordData()) if you want to access any of the fields.

In cases like the EventToSpanEventBridge, this causes unnecessary allocations in cases where log records are not events.

Let's followup on this long time TODO and add dedicated accessors. Minimally, the ones that are needed for the EventToSpanEventBridge use case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jack-berg