Added dynamodb instrumenter for aws v1_11 sdk #12756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverao
reviewed
Nov 20, 2024
There was a problem hiding this comment.
There are some CI failings, you can refer to related contribution docs to fix them:
steverao
reviewed
Nov 20, 2024
...brary/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/TracingRequestHandler.java
Outdated
Show resolved
Hide resolved
|
The tests were recently rewritten so I need to update them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12493
Added a dynamo instrumenter for the aws v1_11 sdk. The most important thing this provides is the db.system attribute which was previously missing and is required according to the sem conv for dynamo. Table name has also been added as an attribute, the instrumenter can continue to be enhanced to add additional 'recommended' attributed from the semantic conventions.