Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file support and how to integrate with sys.config #769

Open
tsloughter opened this issue Sep 12, 2024 · 1 comment
Open

Configuration file support and how to integrate with sys.config #769

tsloughter opened this issue Sep 12, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@tsloughter
Copy link
Member

OpenTelemetry has a new configuration file specification, example: https://github.com/open-telemetry/opentelemetry-configuration/blob/main/examples/sdk-config.yaml that we need to support.

It is defined that if used by the user that environment variables (which can be substituted into the config) are ignored.

I think for easiest integration we have to also ignore sys.config but this may be contentious and confusing. Instead support a path to the file in the configuration but then if that is given we ignore the rest.

@tsloughter tsloughter added enhancement New feature or request question Further information is requested labels Sep 12, 2024
@jamescarr
Copy link

I think being intentrional is the best approach. If I am providing a configuration file in other applications I kind of presume it is going to ignore any environment variables unless they are used in string interpolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants