Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a sorted list for attributes in metrics #704

Open
tsloughter opened this issue Mar 5, 2024 · 1 comment
Open

Use a sorted list for attributes in metrics #704

tsloughter opened this issue Mar 5, 2024 · 1 comment
Labels
bug Something isn't working metrics
Milestone

Comments

@tsloughter
Copy link
Member

Because a key in a matchspec acts as a match and not an equality check the ets lookups based on keys using attributes in metrics will result in incorrect results. For example, an empty set of attributes #{} would match any metric, no matter the attributes it has, when used in an ets match/select.

I believe moving to a guard check will slow the key lookup down so we must convert attributes to a list when used in a metric key.

@tsloughter tsloughter added bug Something isn't working metrics labels Mar 5, 2024
@tsloughter tsloughter added this to the Metrics GA milestone Mar 5, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Erlang backlog Mar 5, 2024
@tsloughter
Copy link
Member Author

Renaming this because the more important issue issue is normalizing attribute keys since right now a and <<"a">> would make different metric streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant