Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conditional compilation .NET #3798

Open
Kielek opened this issue Nov 21, 2024 · 0 comments
Open

Simplify conditional compilation .NET #3798

Kielek opened this issue Nov 21, 2024 · 0 comments

Comments

@Kielek
Copy link
Contributor

Kielek commented Nov 21, 2024

There are many places in the code where we needed to change NET60_OR_GREATER to NET80_OR_GREATER. It seems like the intent of the directive in many, if not most of those locations was to use a version of the code that only applied to the .net build target and not the .net framework build target.

Where appropriate, should we change NET80_OR_GREATER to either NET or !NETFRAMEWORK, to make the intent clearer?

Originally posted by @nrcventura in #3796 (review)

@Kielek Kielek mentioned this issue Nov 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant