Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Contributions highlight social card text is off #74

Open
2 tasks done
nickytonline opened this issue Jan 11, 2024 · 7 comments
Open
2 tasks done

Bug: Contributions highlight social card text is off #74

nickytonline opened this issue Jan 11, 2024 · 7 comments
Labels
🐛 bug Something isn't working 👀 needs-triage

Comments

@nickytonline
Copy link
Member

Describe the bug

I guess it depends on the text in the description of the highlight, but in some instances, it goes outside of the image and partially over the avatar.

Steps to reproduce

  1. Share https://app.opensauced.pizza/feed/926 on Slack or somewhere else where the social card will appear.

  2. Notice the text is off in the image.

CleanShot 2024-01-11 at 11 18 03

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@nickytonline nickytonline added the 🐛 bug Something isn't working label Jan 11, 2024
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member Author

Whoever works on this will have to run ntl dev (the Netlify CLI), instead of the regular npm run dev as the social card is generated in a Netlify Edge Function, https://github.com/open-sauced/app/blob/6db2b780894c0c9b49f182c6acaf056730668c39/netlify/edge-functions/card.tsx

@OgDev-01
Copy link
Contributor

This is related to https://github.com/open-sauced/opengraph repo. I did some work there. i can take a look at setting a width for the description so it doesn’t overflow across the avatar

@OgDev-01
Copy link
Contributor

Might be worth transferring this issue over to the opengraph repo as well

@OgDev-01
Copy link
Contributor

This seems wierd.

More description

image

Less description

image

Will visit this and investigate more as soon as i can

@nickytonline
Copy link
Member Author

nickytonline commented Jan 12, 2024

This is related to open-sauced/opengraph repo. I did some work there. i can take a look at setting a width for the description so it doesn’t overflow across the avatar

Ahh, I could've sworn this was the edge function I mentioned above. I'll move it to over there then.

@nickytonline nickytonline transferred this issue from open-sauced/app Jan 12, 2024
@takanome-dev
Copy link
Contributor

@nickytonline I'm pretty sure the html tag broke the layout. I did add sanitization but we didn't have the result we wanted. Have a look at #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👀 needs-triage
Projects
None yet
Development

No branches or pull requests

3 participants