feature: Using Tailwind discussion #7
Comments
|
We can add Tailwind in the smaller UI components of #6 , so it's just kind of one-time thing. |
|
Proposed tailwind so we can re-use some of the design from the frontend, it's sort of a pun like "how much do you want to complicate the perfectly portable pure html+css design you implemented now?"; it's not a serious proposal unless we can all agree we need the "insights design" and it's not sustainable to do it like we are doing it right now. You quoted pains copy-pasting the design from the Figma file ... if we switch to tailwind you can't do that anymore, either have to find some $80/month plugin or do it yourself. Both are illogical things to do. Think we need to have another design conversation around the social graph instance, when we set out to do it, we had to decide on insights vs backend architecture and went with the backend, storing the generated images on S3 and never actually hitting a live server in the client. |
|
it's supported out of the box: https://github.com/vercel/satori/blob/3a16fddc9e3615681cbf7a1cd0c1352ca6a3b769/src/handler/tailwind.ts#L4 |
## [1.2.0-beta.6](v1.2.0-beta.5...v1.2.0-beta.6) (2023-04-09) ### 🐛 Bug Fixes * correct all tailwind classes except gaps ([fe44711](fe44711)), closes [#7](#7) * correct user languages sizing issues ([5846c42](5846c42)) * correct username display instead of full name ([1454cbb](1454cbb)), closes [#11](#11)
|
🎉 This issue has been resolved in version 1.2.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [2.0.0](v1.1.2...v2.0.0) (2023-04-11) ### ⚠ BREAKING CHANGES * id changed to :username in earlier commits, this is catching it up ### 🔁 Continuous Integration * correct live release url in github actions deployment ([4a434e6](4a434e6)) ### 🎨 Styles * add tailwind proof of concept ([8594508](8594508)) ### 📝 Documentation * update live environments lins and document local development ([08cead1](08cead1)) ### 🍕 Features * add boilerplate s3-client sdk code connected to digital ocean spaces ([a4a71e3](a4a71e3)) * add custom cdn endpoint configuration for s3 bucket on digital ocean ([077e473](077e473)), closes [#18](#18) * implement digital ocean spaces s3 client storage and cache images 3 days ([792992e](792992e)) * implement no-content verification strategy ([6efe0e6](6efe0e6)) * optimize image loading and return errors ([7c6f199](7c6f199)), closes [#17](#17) ### 🐛 Bug Fixes * correct all tailwind classes except gaps ([fe44711](fe44711)), closes [#7](#7) * correct app spec GET automatic rewrites of HEAD ([3047cec](3047cec)) * correct dark logo render and make it static ([dc9f3a4](dc9f3a4)) * correct languages displaying less than 0.5% ([bee0e6e](bee0e6e)) * correct server generation environment ([68d0202](68d0202)) * correct user languages sizing issues ([5846c42](5846c42)) * correct username display instead of full name ([1454cbb](1454cbb)), closes [#11](#11) * correct yoga layout double styling, remove repo icon extrenaous classes ([d84015b](d84015b)) * correct zero contribution top repos language distribution ([7d82c0d](7d82c0d)) ### 🤖 Build System * update dependencies and ts5 ([715e349](715e349)) * update graphql types ([f7db713](f7db713))
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Type of feature
Select the type of feature request, the lowercase should also be the PR prefix.
Current behavior
Currently the css is added to the elements by directly copy-pasting it from figma without modification. This gave a speed advantage when directly copying the design.
@0-vortex suggested using Tailwind in the project instead of direct CSS. We decided to move the conversation into this new issue to have more freedom in discussing each's pros & cons.
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.
Contributing Docs
If you plan on contributing code please read - Contribution Guide
The text was updated successfully, but these errors were encountered: