Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: recommened node and npm versions seem out of sync #56

Open
2 tasks done
jpmcb opened this issue Jun 20, 2023 · 2 comments
Open
2 tasks done

Bug: recommened node and npm versions seem out of sync #56

jpmcb opened this issue Jun 20, 2023 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@jpmcb
Copy link
Member

jpmcb commented Jun 20, 2023

Describe the bug

Per the docs:

In order to run the project we need the following software binaries installed on our development machines: node>=18.15.0 npm>=9.6.3

but the latest LTS version of node 18 (v18.16.1) comes with npm v9.5.1.

https://nodejs.org/en/download

Maybe this needs to be updated? Or is it expected users should have a newer out-of-band version of npm from their node version?

Steps to reproduce

N/a

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@jpmcb jpmcb added the 🐛 bug Something isn't working label Jun 20, 2023
@jpmcb
Copy link
Member Author

jpmcb commented Jun 20, 2023

Hmmmm seems like attempting npm ci with the older version didn't work anyways (given the restriction in the engines field of the package.json. Upgrading to the newest npm works.

@bdougie bdougie added this to the Open Graph Social Cards milestone Jul 14, 2023
@MartiinWalsh
Copy link

Also, the package.json specifies "node": ">= 16.19.1".

Should we update the package.json to require Node version 18.15.0 or later to match the documentation.

Alternatively, revise the documentation to match the package.json, stating that the project requires Node version 16.19.1 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants