Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add env variable for the absolute path of server url location & update fixed localhost endpoint accesses #4

Closed
1 of 13 tasks
Deadreyo opened this issue Mar 20, 2023 · 1 comment

Comments

@Deadreyo
Copy link
Contributor

Type of feature

Select the type of feature request, the lowercase should also be the PR prefix.

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Current behavior

Is your feature request related to a problem? Please describe.

Currently in places in the code, we get some resources by calling our own endpoints, example:
<img src="http://localhost:3006/favicon.ico" ...
This only works for local development and will need adjusting to be ready for deployment.

Suggested solution

Describe the solution you'd like.

Add an environment variable to hold the url of the server and update such pieces of code in the app to use that variable.

Alternatively if possible, find a way to be able to import images in satori without visiting server's own endpoints for them.

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs
@0-vortex
Copy link
Contributor

0-vortex commented Apr 4, 2023

Sort of done in https://github.com/open-sauced/opengraph.opensauced.pizza/releases/tag/v1.0.0 we using base64 instead of the static folder, can be improved but not with env vars now, with our design system maybe

@0-vortex 0-vortex closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants