Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Store static images & directly embed their data #32

Open
1 of 13 tasks
Deadreyo opened this issue Apr 12, 2023 · 1 comment
Open
1 of 13 tasks

feature: Store static images & directly embed their data #32

Deadreyo opened this issue Apr 12, 2023 · 1 comment

Comments

@Deadreyo
Copy link
Contributor

Type of feature

Select the type of feature request, the lowercase should also be the PR prefix.

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Current behavior

Currently we embed http links of our static images like our logo
like (a mock example) src="https://insights.opensauced.pizza/logo1.png"

Since they are static, it is probably much more efficient to instead embed them as base64 data directly in the templates.

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs
@0-vortex
Copy link
Contributor

Base64 would be converted from one of the below methods:

image

I support the idea, we should make some common/assets/static folder inside our generated server code (src) to handle the the files πŸ•

@bdougie bdougie added this to the Open Graph Social Cards milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants