Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve code quality #27

Open
1 of 13 tasks
Deadreyo opened this issue Apr 11, 2023 · 0 comments
Open
1 of 13 tasks

refactor: Improve code quality #27

Deadreyo opened this issue Apr 11, 2023 · 0 comments

Comments

@Deadreyo
Copy link
Contributor

Type of feature

Select the type of feature request, the lowercase should also be the PR prefix.

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Current behavior

Some things are off or can be improved a bit.

Suggested solution

Some examples:

  • Declare service.ts files' private functions as private.
  • Declare service.ts files' public functions as public (for easier noticing).
  • Remove some unneeded brackets
  • Any other improvements on the fly.

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added this to the Open Graph Social Cards milestone May 17, 2023
@bdougie bdougie changed the title refractor: Improve code quality refactor: Improve code quality Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants