Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: top repositories for a user can be 0 #15

Open
6 tasks done
0-vortex opened this issue Apr 6, 2023 · 3 comments
Open
6 tasks done

bug: top repositories for a user can be 0 #15

0-vortex opened this issue Apr 6, 2023 · 3 comments
Labels
🐛 bug Something isn't working 🖍needs-design

Comments

@0-vortex
Copy link
Contributor

0-vortex commented Apr 6, 2023

Describe the bug

When checking a user's top repositories we are filtering out personal and repositories that have not received a push within the last 30 days. If that array is 0, a different display logic should be used, or a placeholder instead.

Steps to reproduce

Check out @bdougie 🍕

Environment

Select the places where the issue can be reproduced (that you know of).

  • Local
  • Testing
  • Development
  • Production

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs
@0-vortex 0-vortex added the 🐛 bug Something isn't working label Apr 6, 2023
@OgDev-01
Copy link
Contributor

OgDev-01 commented Apr 7, 2023

I don't know what logic needs to be added... But IMHO, we can have a placeholder alternative if the array of repos is equal to zero. (Not sure about the look of a placeholder though), maybe @getaheaddev can sketch out something.

@bdougie
Copy link
Member

bdougie commented Apr 11, 2023

My suggestion is to add copy where the repo list is in small text along with a generic language bar with 5 colors.

"Sometime open source is about the friends you along the way."

@getaheaddev
Copy link

I'm not understanding the question @OgDev-01 I will try and apply an example of what @bdougie suggested though.

@bdougie bdougie added this to the Open Graph Social Cards milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🖍needs-design
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants