Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: incorrect text length calculation #13

Open
6 tasks done
0-vortex opened this issue Apr 6, 2023 · 1 comment
Open
6 tasks done

bug: incorrect text length calculation #13

0-vortex opened this issue Apr 6, 2023 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@0-vortex
Copy link
Contributor

0-vortex commented Apr 6, 2023

Describe the bug

The fonts we have used in the social cards are not monospaced, making the top repos go out of the view box depending on the text displayed, not the number of characters.

Steps to reproduce



Environment

Select the places where the issue can be reproduced (that you know of).

  • Local
  • Testing
  • Development
  • Production

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs
@0-vortex 0-vortex added the 🐛 bug Something isn't working label Apr 6, 2023
@Deadreyo
Copy link
Contributor

Deadreyo commented May 9, 2023

This was band-aided in #42 by decreasing the number of repos displayed from 4 to 3. A better solution would be counting the number of characters in the top 4 repos and dynamically checking if we can fit 4 repos in or if we will resort to 3 for each individual user.

@bdougie bdougie added this to the Open Graph Social Cards milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants