Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insights social card generation #51

Merged
merged 14 commits into from Jun 8, 2023
Merged

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Jun 6, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR introduces several updates and new features to the project.

Firstly, the tailwind config has been updated to improve the styling of the application. Additionally, insight entity interfaces have been added as part of the chore to enhance the codebase.

New features include the creation of an insight template, insight services, and insight modules. The logic for generating insights cards has also been refactored to improve performance.

The PR also includes several linting updates and a test script for insights. The highlight title font weight has been updated for better readability.

Finally, comments have been removed and the test output has been set to PNG format.

Generated using OpenSauced.

Related Tickets & Documents

Closes #47

Mobile & Desktop Screenshots/Recordings

Insights social card

image image

Highlights social card

image image image

User social card

image image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❀️! πŸŽ‰πŸ•
Say hello by joining the conversation in our Discord

@OgDev-01 OgDev-01 marked this pull request as ready for review June 7, 2023 10:05
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdougie
Copy link
Member

bdougie commented Jun 7, 2023

@OgDev-01 did you update the design to match #44

@OgDev-01
Copy link
Contributor Author

OgDev-01 commented Jun 7, 2023

@OgDev-01 did you update the design to match #44

Yes i did...

@OgDev-01
Copy link
Contributor Author

OgDev-01 commented Jun 7, 2023

Ooh Sorry... I think I followed the wrong link @bdougie... These are still the old designs :<

I'll update all to match the new design on a new PR.

@bdougie
Copy link
Member

bdougie commented Jun 7, 2023

Perhaps do another pr for #44. I was only reviewing the insights card and notice the other issue on here.

@brandonroberts brandonroberts merged commit 8a82a48 into beta Jun 8, 2023
5 checks passed
@brandonroberts brandonroberts deleted the 47-insights-social-card branch June 8, 2023 13:33
github-actions bot pushed a commit that referenced this pull request Jun 8, 2023
## [2.2.0-beta.1](v2.1.2-beta.1...v2.2.0-beta.1) (2023-06-08)

### πŸ• Features

*  insights social card generation ([#51](#51)) ([8a82a48](8a82a48))
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

πŸŽ‰ This PR is included in version 2.2.0-beta.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 8, 2023
github-actions bot pushed a commit that referenced this pull request Jun 20, 2023
## [2.2.0](v2.1.1...v2.2.0) (2023-06-20)

### πŸ› Bug Fixes

* remove issue templates ([#49](#49)) ([778ad4e](778ad4e))

### πŸ• Features

*  insights social card generation ([#51](#51)) ([8a82a48](8a82a48))

### πŸ“ Documentation

* update instructions on testing cards generation locally ([#53](#53)) ([e152d09](e152d09))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.2.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Generate social Cards for insights pages
3 participants