New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add node emoji to highlight cards #50
Comments
Clicking on the link in the issue gave me this issue:
Refreshing the page solved the issue. |
This is the related component in this repo:
This is an example of fixing it based on the suggestion in the issue: |
I worked on this and used But one of the things that I got curious about is the HTML/image convertor: the solution might be there: I will do further testing later. |
Satory/Vercel is using an API/CDN to get the SVG of the emoji: We might need to implement something similar: I will stop here now and check it at another time. |
This is do to the image generation failing because the data is not ready, I believe. Refreshing hits the cache. We will honestly need to look into using an edge function for all of this in the future. That work is being explored here. open-sauced/app#1400 I will look at this deeper on Monday. Interesting that nore-emoji did not work in this case. |
Thank you for that! Looking forward to read your review. |
Shower thoughts: This issue could be a great case study for why you need to provide a suggestion to your issue. |
Indeed. I need to get in more issues and make proper suggestions. Hoping we can start coordinating more triaging with the team. |
I would like to help in case if I can do anything there, when the PR get accepted I am thinking to write a blog about this. Focusing on the value of providing suggested solutions. |
馃帀 This issue has been resolved in version 2.4.0-beta.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
馃帀 This issue has been resolved in version 2.4.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Type of feature
馃崟 Feature
Current behavior
Emojis are not being generated in the card preview.
https://insights.opensauced.pizza/feed/171
Suggested solution
Use node-emoji wrapper for copy. We use it in open-sauced/hot
https://github.com/open-sauced/hot/pulls?q=is%3Apr+emoji+is%3Aclosed
Additional context
No response
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: