Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Newsletter sign up no longer collects a user's email #336

Open
nickytonline opened this issue Jul 29, 2024 · 3 comments · Fixed by #337
Open

Bug: Newsletter sign up no longer collects a user's email #336

nickytonline opened this issue Jul 29, 2024 · 3 comments · Fixed by #337
Assignees
Labels

Comments

@nickytonline
Copy link
Member

nickytonline commented Jul 29, 2024

While investigating a build error in the app, open-sauced/app#3796, @netlify/plugin-nextjs@5 requires migration steps to support Netlify Forms. Refer to https://ntl.fyi/next-runtime-forms-migration for migration example., I discovered that our newsletter signup no longer collects emails in the app. I tried it out in the landing-page, and it's the same behviour, it no longer works.

The last one collected appears to have been in March, but a couple tests I did does not collect the emails.

We're using the pages router, but it appears we may need to do the same fix as suggested in the Netlify docs to be able to use Netlify Forms with Next.js. Not sure when this broke.

The fix is detailed at https://docs.netlify.com/frameworks/next-js/overview/#breaking-changes.

We haven't seen build failures in the landing-page project yet, but when we do, you'll need to add this environment variable to the project temporarily until this issue is fixed, and then remove the env var, once this issue is resolved.

CleanShot 2024-07-29 at 13 20 54

@nickytonline nickytonline added 🐛 bug Something isn't working core team work labels Jul 29, 2024
@1Dedios
Copy link

1Dedios commented Aug 7, 2024

Hey, can I be assigned this bug?

@jpmcb
Copy link
Member

jpmcb commented Aug 8, 2024

Sorry, @1Dedios, this is a critical issue the core-team will have to tackle! Thanks for volunteering however!

@jpmcb
Copy link
Member

jpmcb commented Aug 9, 2024

Reopening - we'll want to revisit this and bring back the form since the fix in #337 was more or less a quickfix.

@jpmcb jpmcb reopened this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants