Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed blog featured post images that was cutoff #357

Closed

Conversation

dev-phantom
Copy link
Contributor

Description

This PR fixes the feature blog post images that was cutoff

Related Tickets & Documents

Fixes #292

Mobile & Desktop Screenshots/Recordings

before:
image

after:
image

Note

This pr also fixes the minimum height issue on non featured post. this is to help maintain layout consistency

before:

image

now:
image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 8ba6f13
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/66e8698b61a055000839d16c
😎 Deploy Preview https://deploy-preview-357--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dev-phantom
Copy link
Contributor Author

@BekahHW
please ma i need your review on this

is it inline with the solution you suggested?

@brandonroberts brandonroberts requested a review from a team September 10, 2024 13:51
@BekahHW
Copy link
Member

BekahHW commented Sep 10, 2024

@dev-phantom this is looking much better. I did notice that the font seems to be stretched in the new version. Generally, we don't have titles in the image, so maybe we can just add a new image with the right dimensions.

Updated

image

Current

image

components/sections/blog/FeaturedPost.tsx Outdated Show resolved Hide resolved
components/sections/blog/components/Post.tsx Outdated Show resolved Hide resolved
@nickytonline
Copy link
Member

The featured blog post looks good @dev-phantom, I'm just wondering about the actual blog post page. Should we still resize as the page gets bigger or stop at the actual image size? I'm leaning to stop at the actual image size @BekahHW.

CleanShot 2024-09-10 at 14 33 49

@BekahHW
Copy link
Member

BekahHW commented Sep 12, 2024

The featured blog post looks good @dev-phantom, I'm just wondering about the actual blog post page. Should we still resize as the page gets bigger or stop at the actual image size? I'm leaning to stop at the actual image size @BekahHW.

CleanShot 2024-09-10 at 14 33 49 CleanShot 2024-09-10 at 14 33 49

@dev-phantom this is a bit outside of the scope of the original issue, but if you're interested in making this improvement as well, that would be great. Let me know.

@dev-phantom
Copy link
Contributor Author

The featured blog post looks good @dev-phantom, I'm just wondering about the actual blog post page. Should we still resize as the page gets bigger or stop at the actual image size? I'm leaning to stop at the actual image size @BekahHW.

CleanShot 2024-09-10 at 14 33 49 CleanShot 2024-09-10 at 14 33 49

@dev-phantom this is a bit outside of the scope of the original issue, but if you're interested in making this improvement as well, that would be great. Let me know.

"Should we still resize as the page gets bigger or stop at the actual image size? "

What your take on this ma @BekahHW so as to make this improvement

@dev-phantom
Copy link
Contributor Author

please i want to go back to this branch cause i've made updates after this which i added to a different branch

but if i checkout back to this branch i still get the recent updates i maded in the recent branch there please is there a way i could fix this @nickytonline

@BekahHW
Copy link
Member

BekahHW commented Sep 13, 2024

please i want to go back to this branch cause i've made updates after this which i added to a different branch

but if i checkout back to this branch i still get the recent updates i maded in the recent branch there please is there a way i could fix this @nickytonline

If you run git log, does it show the commits you don't want?

@dev-phantom
Copy link
Contributor Author

please i want to go back to this branch cause i've made updates after this which i added to a different branch
but if i checkout back to this branch i still get the recent updates i maded in the recent branch there please is there a way i could fix this @nickytonline

If you run git log, does it show the commits you don't want?

yes

1 similar comment
@dev-phantom
Copy link
Contributor Author

please i want to go back to this branch cause i've made updates after this which i added to a different branch
but if i checkout back to this branch i still get the recent updates i maded in the recent branch there please is there a way i could fix this @nickytonline

If you run git log, does it show the commits you don't want?

yes

@BekahHW
Copy link
Member

BekahHW commented Sep 13, 2024

@dev-phantom so it looks like maybe you accidentally committed to this branch. You can remove those commits, but make sure you have them in the branch they're supposed to be in so you don't lose your work. This might be helpful.

@dev-phantom
Copy link
Contributor Author

@dev-phantom so it looks like maybe you accidentally committed to this branch. You can remove those commits, but make sure you have them in the branch they're supposed to be in so you don't lose your work. This might be helpful.

thank yo so much for this

@nickytonline nickytonline force-pushed the fix-blog-featured-post branch 5 times, most recently from 3999299 to 4d19aaf Compare September 16, 2024 17:16
@jpmcb jpmcb mentioned this pull request Sep 16, 2024
4 tasks
@dev-phantom
Copy link
Contributor Author

Sorry to ask @nickytonline I was working on the suggestion raised my @BekahHW and was hoping to add it to this PR

Do you suggest i just pull the latest update and create a new pr since this wasn't merged or just create a new pr and push the suggestion?

@nickytonline
Copy link
Member

@dev-phantom , sorry for the confusion. Ignore what I said. I had accidentally created a new PR for some other work with a local copy of your branch. This PR is still good to work on.

@dev-phantom
Copy link
Contributor Author

@dev-phantom , sorry for the confusion. Ignore what I said. I had accidentally created a new PR for some other work with a local copy of your branch. This PR is still good to work on.

It closed

1 similar comment
@dev-phantom
Copy link
Contributor Author

@dev-phantom , sorry for the confusion. Ignore what I said. I had accidentally created a new PR for some other work with a local copy of your branch. This PR is still good to work on.

It closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: featured post cuts off img
3 participants