-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed blog featured post images that was cutoff #357
Conversation
✅ Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@BekahHW is it inline with the solution you suggested? |
@dev-phantom this is looking much better. I did notice that the font seems to be stretched in the new version. Generally, we don't have titles in the image, so maybe we can just add a new image with the right dimensions. UpdatedCurrent |
The featured blog post looks good @dev-phantom, I'm just wondering about the actual blog post page. Should we still resize as the page gets bigger or stop at the actual image size? I'm leaning to stop at the actual image size @BekahHW. |
@dev-phantom this is a bit outside of the scope of the original issue, but if you're interested in making this improvement as well, that would be great. Let me know. |
"Should we still resize as the page gets bigger or stop at the actual image size? " What your take on this ma @BekahHW so as to make this improvement |
please i want to go back to this branch cause i've made updates after this which i added to a different branch but if i checkout back to this branch i still get the recent updates i maded in the recent branch there please is there a way i could fix this @nickytonline |
If you run git log, does it show the commits you don't want? |
yes |
1 similar comment
yes |
@dev-phantom so it looks like maybe you accidentally committed to this branch. You can remove those commits, but make sure you have them in the branch they're supposed to be in so you don't lose your work. This might be helpful. |
thank yo so much for this |
3999299
to
4d19aaf
Compare
4d19aaf
to
8ba6f13
Compare
Sorry to ask @nickytonline I was working on the suggestion raised my @BekahHW and was hoping to add it to this PR Do you suggest i just pull the latest update and create a new pr since this wasn't merged or just create a new pr and push the suggestion? |
@dev-phantom , sorry for the confusion. Ignore what I said. I had accidentally created a new PR for some other work with a local copy of your branch. This PR is still good to work on. |
It closed |
1 similar comment
It closed |
Description
This PR fixes the feature blog post images that was cutoff
Related Tickets & Documents
Fixes #292
Mobile & Desktop Screenshots/Recordings
before:
after:
Note
This pr also fixes the minimum height issue on non featured post. this is to help maintain layout consistency
before:
now:
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?