-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: testimonial twitter link converter #157
feature: testimonial twitter link converter #157
Conversation
✅ Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looks good for me, |
@a0m0rajab That's the PR number you're referring to, I already mentioned the issue number in PR. Both will get closed automatically once PR is merged. |
sorry about the mistake for the PR, you just mentioned the issue without adding a keyword, you need to have a keyword like: Here is the related documentation: GitHub docs, linking work with issues when you link it you will have it added to the issue as well in the development: |
@a0m0rajab I didn't know that was a thing. Thanks for pointing me to the docs! 😄 |
You are welcome! Looking forward to see how the 100daysofoss challenge will end for you! |
No, I didn't even know we can do that. I will try adding this one! 🥰 |
Awesome! feel free to add your PRs and enjoy the experience, a blog and issue post is going to arrive soon as well! |
Thank you for sharing that, I just reacted to it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this @wasimapinjari
Description
This PR adds the feature of converting testimonial Twitter username handles to Twitter links
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #29
Desktop Screenshots
BEFORE
AFTER
Added tests?
Added to documentation?