Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: blog post doesn't show up on landing page #132

Closed
2 tasks done
BekahHW opened this issue Jul 10, 2023 · 4 comments · Fixed by #134
Closed
2 tasks done

Bug: blog post doesn't show up on landing page #132

BekahHW opened this issue Jul 10, 2023 · 4 comments · Fixed by #134
Assignees
Labels
🐛 bug Something isn't working 👀 needs triage

Comments

@BekahHW
Copy link
Member

BekahHW commented Jul 10, 2023

Describe the bug

The Intro to Open Source blog post is on the site, but is only viewable if you have the url.

Steps to reproduce

Here's the live url: https://opensauced.pizza/blog/open-source-101:-a-beginner's-guide-to-getting-started

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@BekahHW BekahHW added 🐛 bug Something isn't working 👀 needs triage labels Jul 10, 2023
@BekahHW
Copy link
Member Author

BekahHW commented Jul 10, 2023

@bdougie I can't assign you, so wanted to tag you here.

@bdougie bdougie self-assigned this Jul 10, 2023
@bdougie
Copy link
Member

bdougie commented Jul 11, 2023

confirmed it shows on local dev. Curious if you have thoughts on why that is @shamimbinnur

Screen Shot 2023-07-10 at 11 09 04 PM

@shamimbinnur
Copy link
Contributor

shamimbinnur commented Jul 11, 2023

@bdougie Initially, all blogs were fetched unsorted from the backend, resulting in potential blog omissions when sorting was done on the frontend. This sorting operation shouldn't be performed on the frontend. Refactored the code on #134 to fetch sorted data directly from the backend. Hopefully this PR will fix this issue.

@bdougie
Copy link
Member

bdougie commented Jul 11, 2023

@bdougie Initially, all blogs were fetched unsorted from the backend, resulting in potential blog omissions when sorting was done on the frontend. This sorting operation shouldn't be performed on the frontend. Refactored the code on #134 to fetch sorted data directly from the backend. Hopefully this PR will fix this issue.

This helpful context and the correct approach. Featured posts are no longer needed to be fetched as well.

Appreciate the PR. Let's move forward with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👀 needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants