-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Landing page update (Revised version) #120
Conversation
β Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
<Typography alignLarge="left" alignSmall="left" variant="body3"> | ||
Working with team? | ||
<span> | ||
<Link href="/enterprise"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Link href="/enterprise"> | |
<Link href="/enterprise"> |
This link is broken. And can this be /teams
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdougie We do not have a page on '/teams' also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be the original landing page, all the content that was previously on the landing page.
Hey Shamim, thanks for this. I think we can go live with this and ship it but I'd like to roll these changes out one by one soon after. Changes Page 1/4:
Seems like most of the changes here are due to sizing issues (everything is enlarged). None are red flags so we can go live with this, but as stated earlier, would like to see these changes rolled out. |
Changes Page 4/4:
**That's it. Seems like most of these are scaling differences. None of them are dealbreakers, hence why I think we can go live now, but want to eventually push these changes out when we can. Thanks again @shamimbinnur, great job. |
We needed this done on the 1st of May, so I am merging this in. @chhristopher and @shamimbinnur I create this issue to re implement the old landing on the |
What type of PR is this? (check all applicable)
Description
This is the better-planned revised version of #119.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?