Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Landing page update (Revised version) #120

Merged
merged 26 commits into from
May 3, 2023
Merged

feat: Landing page update (Revised version) #120

merged 26 commits into from
May 3, 2023

Conversation

shamimbinnur
Copy link
Contributor

@shamimbinnur shamimbinnur commented Apr 30, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This is the better-planned revised version of #119.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Apr 30, 2023

βœ… Deploy Preview for opensauced-landing ready!

Name Link
πŸ”¨ Latest commit 644a3e3
πŸ” Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/64525e23a282760008707746
😎 Deploy Preview https://deploy-preview-120--opensauced-landing.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shamimbinnur shamimbinnur marked this pull request as ready for review May 1, 2023 11:39
@shamimbinnur shamimbinnur requested a review from bdougie May 1, 2023 11:39
<Typography alignLarge="left" alignSmall="left" variant="body3">
Working with team?
<span>
<Link href="/enterprise">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Link href="/enterprise">
<Link href="/enterprise">

This link is broken. And can this be /teams instead?

Copy link
Contributor Author

@shamimbinnur shamimbinnur May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdougie We do not have a page on '/teams' also.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be the original landing page, all the content that was previously on the landing page.

@chhristopher
Copy link

Hey Shamim, thanks for this. I think we can go live with this and ship it but I'd like to roll these changes out one by one soon after.

Changes Page 1/4:

  1. Padding
  2. H1 in our original takes up only 2 lines versus the 3 lines in the preview
  3. Padding/sizing
  4. Padding/sizing

Seems like most of the changes here are due to sizing issues (everything is enlarged). None are red flags so we can go live with this, but as stated earlier, would like to see these changes rolled out.

Comparison-1

@chhristopher
Copy link

Changes Page 2/4:

  1. Original design takes up 3 lines versus 4
  2. Padding and sizing

Comparison-2

@chhristopher
Copy link

Changes Page 3/4:

  1. Original design 2 lines versus 3 in preview (scaling issue)
  2. The design element of the cards in the preview is scaled up and too far towards the edge.

Everything here is scaled up compared to the original.

Comparison-3

@chhristopher
Copy link

Changes Page 4/4:

  1. Original 2 lines versus preview 3
  2. Design element padding. The preview element is scaled up

**That's it. Seems like most of these are scaling differences. None of them are dealbreakers, hence why I think we can go live now, but want to eventually push these changes out when we can. Thanks again @shamimbinnur, great job.

Comparison-4

@bdougie
Copy link
Member

bdougie commented May 3, 2023

We needed this done on the 1st of May, so I am merging this in.

@chhristopher and @shamimbinnur I create this issue to re implement the old landing on the /teams route. We need that ASAP.

#121

@bdougie bdougie merged commit 317c896 into main May 3, 2023
4 checks passed
@bdougie bdougie deleted the site-upgrade branch May 3, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants