Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: homepage refresh (deprecated 🚨) #119

Closed
wants to merge 16 commits into from
Closed

Conversation

shamimbinnur
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Apr 24, 2023

βœ… Deploy Preview for opensauced-landing ready!

Name Link
πŸ”¨ Latest commit 8844ad0
πŸ” Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/644bce62706ca900088705a9
😎 Deploy Preview https://deploy-preview-119--opensauced-landing.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdougie
Copy link
Member

bdougie commented Apr 24, 2023

I know this is still a WIP, but want to point out that the images in the preview includes the older images. We will also need to place these images local in the repo, and not on Sanity. Sanity scales the images down a ton.

Screen Shot 2023-04-24 at 12 45 19 PM

Screen Shot 2023-04-24 at 12 45 13 PM

cc @getaheaddev

@bdougie
Copy link
Member

bdougie commented Apr 26, 2023

We need a mobile view of this element.

image

It's too small

@chhristopher
Copy link

Hey @shamimbinnur, communicating here for visibility. Per our discussion: Hi-res images and updated layout/copy. I'll wait for your green light to go through both the desktop and mobile versions and consolidate my feedback to give to you all at once. Thanks!

@shamimbinnur shamimbinnur marked this pull request as ready for review April 26, 2023 10:55
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Only one newsletter needed. Double checking with design see how that got missed
  2. "Click here" needs to go to the previous landing page.

Comment on lines 41 to 43
<a className="text-sm text-wh pt-7" href="#">
Working with a team? Click here
</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a link to the previous landing page at the /teams route.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean https://opensauced.pizza/teams?

Correct

Comment on lines +33 to +35
<Heading alignSmall="center">
$orange-to-yellowThe fast track$orange-to-yellow to open source
</Heading>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two newsletter sections and should be one. We only need email, no name as well.

Screen Shot 2023-04-26 at 5 33 13 AM

Screen Shot 2023-04-26 at 5 32 54 AM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shamimbinnur, let's delete the "Subscribe for Extra Sauce" newsletter section and keep the "The fast track..." section as is (without the 'Your Name' of course). Could we also switch out the copy from "Sign Up" to "Subscribe"?

Thanks

@chhristopher
Copy link

chhristopher commented Apr 26, 2023

Screen Shot 2023-04-26 at 12 45 24 PM

Can we have the bottom copy "Working with the team? Click here" stylized like the other text? The font color and font itself is different from the rest of the body font on our site. Let's also have "Click here" highlighted in our gradient color . Also when we click on "Click here" it goes to a 404, we need to have it route to the enterprise site. @bdougie , did we want to have that opensauced.pizza/enterprise ?

@chhristopher
Copy link

chhristopher commented Apr 26, 2023

The mobile site still has low-res photos and need to be retina scaled. examples attached

File (2)
File (1)
File

@shamimbinnur
Copy link
Contributor Author

The mobile site still has low-res photos and need to be retina scaled. examples attached

File (2) File (1) File

I have just realized that this issue is occurring on the Safari browser. I will explore ways to resolve it."

@chhristopher
Copy link

chhristopher commented Apr 27, 2023

Thanks @shamimbinnur . We've also updated the repo segment on the mobile version, could you take a look and let me know if you have any questions? Also 2 things:

  1. Could we have the "Working with a team? Click here" be the same weight and font as the rest of the body copy on the site?
  2. The feature images get cut out when resizing the window. It then resets into position once the window gets small enough. Could we fix this and make it dynamic?

Screen Shot 2023-04-27 at 12 07 38 AM

Screen Shot 2023-04-27 at 12 07 26 AM

Screen Shot 2023-04-27 at 12 07 18 AM

@shamimbinnur shamimbinnur changed the title feat: homepage refresh feat: homepage refresh (deprecated 🚨) Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants