Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create logic to check if a user has submitted the repository (GET) #353

Open
Tracked by #351
bdougie opened this issue Oct 4, 2022 · 7 comments
Open
Tracked by #351

Create logic to check if a user has submitted the repository (GET) #353

bdougie opened this issue Oct 4, 2022 · 7 comments
Assignees

Comments

@bdougie
Copy link
Member

bdougie commented Oct 4, 2022

What is this?

When submitting a repo to the app, we will need to check if the user has submitted it. This will be needed to identify the most popular users submitting repositories.

What is needed

A hook is needed to fetch https://api.opensauced.pizza/#/Submit%20service/findAllUserSubmitted

At the time of creating this issue, API hooks only exist on the alpha branch. Check here for a reference https://github.com/open-sauced/hot/tree/alpha/src/hooks

In this list, add an item that says Submissions: count

@ikezuby2012
Copy link
Contributor

.take

@github-actions
Copy link

Thanks for taking this on! If you have not already, join the conversation in our Discord

@ikezuby2012
Copy link
Contributor

so if a user has submitted the repo should it end the logic or increase the submission count

@0-vortex
Copy link
Contributor

so if a user has submitted the repo should it end the logic or increase the submission count

It should increase the count, however that is already done in the API. I checked your PR and it's missing the latest beta changes, also because this is an authenticated route, it requires similar code to the user votes, there are WIP prs doing that right now but no copy-pasteable example :/

@ikezuby2012
Copy link
Contributor

Yes, i observed the API handles the submission count, my issue is writing the submission count logic, is it still necessary?

@0-vortex
Copy link
Contributor

Yes, i observed the API handles the submission count, my issue is writing the submission count logic, is it still necessary?

No, this issue is about fetching user submissions, not submitting new repos from the UI, that is issue #352

@ikezuby2012
Copy link
Contributor

Yes, i observed the API handles the submission count, my issue is writing the submission count logic, is it still necessary?

No, this issue is about fetching user submissions, not submitting new repos from the UI, that is issue #352

ok, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants