Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed post highlight message passing #165

Merged
merged 3 commits into from Jun 4, 2023

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Jun 4, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR includes refactoring of the post highlight feature to remove message passing, removal of message listener from github.ts, and addition of tests for getPullRequestAPIURL() function. These changes improve the code quality and ensure better test coverage.

Generated using OpenSauced.

As mentioned before, message passing to a content-script is error-prone and should be avoided if possible.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing tests!

@bdougie bdougie merged commit bad2112 into beta Jun 4, 2023
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 4, 2023
## [1.4.1-beta.3](v1.4.1-beta.2...v1.4.1-beta.3) (2023-06-04)

### πŸ§‘β€πŸ’» Code Refactoring

* removed post highlight message passing  ([#165](#165)) ([bad2112](bad2112))
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

πŸŽ‰ This PR is included in version 1.4.1-beta.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@Anush008 Anush008 deleted the post-highlight-refactor branch June 5, 2023 00:49
github-actions bot pushed a commit that referenced this pull request Jun 6, 2023
## [1.5.0](v1.4.0...v1.5.0) (2023-06-06)

### πŸ§‘β€πŸ’» Code Refactoring

* removed post highlight message passing  ([#165](#165)) ([bad2112](bad2112))

### πŸ• Features

* extension settings ([#132](#132)) ([722cbbe](722cbbe))

### πŸ› Bug Fixes

* highlight redirection, multiple AI generation, draft commit messages ([#163](#163)) ([03b91ab](03b91ab))
* post-highlight-page-check ([#164](#164)) ([ed98eb2](ed98eb2))
* remove configuration enabled check from AI button ([#170](#170)) ([cedca79](cedca79))
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

πŸŽ‰ This PR is included in version 1.5.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

zer0and1 added a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.4.1-beta.3](open-sauced/ai@v1.4.1-beta.2...v1.4.1-beta.3) (2023-06-04)

### πŸ§‘β€πŸ’» Code Refactoring

* removed post highlight message passing  ([#165](open-sauced/ai#165)) ([bad2112](open-sauced/ai@bad2112))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.5.0](open-sauced/ai@v1.4.0...v1.5.0) (2023-06-06)

### πŸ§‘β€πŸ’» Code Refactoring

* removed post highlight message passing  ([#165](open-sauced/ai#165)) ([bad2112](open-sauced/ai@bad2112))

### πŸ• Features

* extension settings ([#132](open-sauced/ai#132)) ([722cbbe](open-sauced/ai@722cbbe))

### πŸ› Bug Fixes

* highlight redirection, multiple AI generation, draft commit messages ([#163](open-sauced/ai#163)) ([03b91ab](open-sauced/ai@03b91ab))
* post-highlight-page-check ([#164](open-sauced/ai#164)) ([ed98eb2](open-sauced/ai@ed98eb2))
* remove configuration enabled check from AI button ([#170](open-sauced/ai#170)) ([cedca79](open-sauced/ai@cedca79))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants