Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: latest highlights #154

Merged
merged 12 commits into from Jun 3, 2023
Merged

feat: latest highlights #154

merged 12 commits into from Jun 3, 2023

Conversation

BekahHW
Copy link
Member

@BekahHW BekahHW commented Jun 2, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds a new constant for the highlights endpoint and fetches the latest highlight from the API to display on the home page. It also adds pagination to the highlights section and allows users to navigate through the highlights. Additionally, it includes a new function to fetch highlights from the API.

Generated using OpenSauced.

Related Tickets & Documents

closes #78

Mobile & Desktop Screenshots/Recordings

Screen.Recording.2023-06-02.at.4.56.57.PM.mov

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

#159

[optional] What gif best describes this PR or how it makes you feel?

I don't know what to say, parks and rec

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@BekahHW BekahHW changed the title Feature/latest highlights Feat: latest highlights Jun 2, 2023
@BekahHW BekahHW changed the title Feat: latest highlights feat: latest highlights Jun 2, 2023
@BekahHW
Copy link
Member Author

BekahHW commented Jun 2, 2023

@bdougie I moved that PR here.

Copy link
Collaborator

@diivi diivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did a little nitpicking.

the design could be improved later,

@@ -17,7 +17,7 @@ export const OPEN_SAUCED_USER_INSIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/u
export const OPEN_SAUCED_AI_PR_DESCRIPTION_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/prs/description/generate`;
export const OPEN_SAUCED_USER_HIGHLIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/user/highlights`;
export const OPEN_SAUCED_AI_CODE_REFACTOR_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/prs/suggestion/generate`;

export const OPEN_SAUCED_HIGHLIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/highlights/list`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const OPEN_SAUCED_HIGHLIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/highlights/list`;
export const OPEN_SAUCED_HIGHLIGHTS_LIST_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/highlights/list`;

to match the naming convention above.

src/utils/fetchOpenSaucedApiData.ts Show resolved Hide resolved
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good minimal viable feature. Once the nits are addressed, we can merge this.

Great job @BekahHW, appreciate the contribution.

@bdougie
Copy link
Member

bdougie commented Jun 3, 2023

Going to merge as is and focus on the comments here #159

@bdougie bdougie merged commit 0ccd0e7 into beta Jun 3, 2023
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 3, 2023
## [1.4.0-beta.1](v1.3.1-beta.5...v1.4.0-beta.1) (2023-06-03)

### πŸ• Features

* latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7))
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

πŸŽ‰ This PR is included in version 1.4.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 3, 2023
## [1.4.0](v1.3.0...v1.4.0) (2023-06-03)

### βœ… Tests

* add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac))
* add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6))

### πŸ› Bug Fixes

* Post a highlight ([#101](#101)) ([e3b7051](e3b7051))
* remove auto-take message from triage.yml ([258a828](258a828))
* rename triage.yml ([3b9a14b](3b9a14b))
* undefined config during build ([#158](#158)) ([c986086](c986086))

### πŸ• Features

* latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7))
* uses username on highlight instead of full name ([#162](#162)) ([801fe5a](801fe5a))
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

πŸŽ‰ This PR is included in version 1.4.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@Anush008 Anush008 deleted the feature/latest-highlights branch June 3, 2023 15:47
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.4.0-beta.1](open-sauced/ai@v1.3.1-beta.5...v1.4.0-beta.1) (2023-06-03)

### πŸ• Features

* latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.4.0](open-sauced/ai@v1.3.0...v1.4.0) (2023-06-03)

### βœ… Tests

* add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac))
* add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6))

### πŸ› Bug Fixes

* Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051))
* remove auto-take message from triage.yml ([258a828](open-sauced/ai@258a828))
* rename triage.yml ([3b9a14b](open-sauced/ai@3b9a14b))
* undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086))

### πŸ• Features

* latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7))
* uses username on highlight instead of full name ([#162](open-sauced/ai#162)) ([801fe5a](open-sauced/ai@801fe5a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: List the latest Highlights
3 participants