Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support Firefox extensions #194

Open
2 tasks done
jpmcb opened this issue Jun 22, 2023 · 8 comments
Open
2 tasks done

Feature: Support Firefox extensions #194

jpmcb opened this issue Jun 22, 2023 · 8 comments
Assignees

Comments

@jpmcb
Copy link
Member

jpmcb commented Jun 22, 2023

Type of feature

🍕 Feature

Current behavior

Currently, the OpenSauced.ai browser extension is not supported in Firefox. It'd be awesome to also support this in Firefox!

Suggested solution

Related to #1 which initially mentioned cross building / deploying to both Chrome and Firefox.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie
Copy link
Member

bdougie commented Jun 23, 2023

The manifest is the same as chrome I believe. I think the only thing needed is me creating a developer account for add-ons and uploading the zip.

I start that process now

@bdougie bdougie self-assigned this Jun 23, 2023
@bdougie bdougie added this to the Extension Features milestone Jun 23, 2023
@bdougie
Copy link
Member

bdougie commented Jun 27, 2023

When attempting to upload the extension to the firefox addon submission form, I was met with this error. Looking into what is causing this.

Screen Shot 2023-06-27 at 1 32 34 PM

@nickytonline have you seen this before. Anything expected to submit a chrome extension to Firefox?

@nickytonline
Copy link
Member

nickytonline commented Jul 4, 2023

I haven't seen that error before, but I know that one thing Firefox does not support is manifest v3 which Chrome requires. Firefox currently supports manifest v2 unless that changed recently. Maybe it's related to that.

I can take a peek at my own extension to compare, i.e. https://github.com/nickytonline/a11y-twitter

Just on mobile atm

@nickytonline
Copy link
Member

nickytonline commented Jul 4, 2023

Looks like Firefox supports manifest v3 as of Firefox 109. See https://extensionworkshop.com/documentation/publish/distribute-manifest-versions/.

Just reading some more about it. How are we currently bundling the extension? I looked in the npm scripts and GitHub workflows, but don't see anywhere where we zip the extension assets. Is it a manual process doing the zip atm?

Also, potentially silly question when you do bundle the extension for Firefox, is the manifest in the bundle? I'm assuming yes, but just asking the obvious before digging more.

@bdougie
Copy link
Member

bdougie commented Jul 11, 2023

Also, potentially silly question when you do bundle the extension for Firefox, is the manifest in the bundle? I'm assuming yes, but just asking the obvious before digging more.

no, TIL

@bdougie
Copy link
Member

bdougie commented Aug 1, 2023

Spent some time preparing to upload the addon to Firefox. Things. I learned:

  1. We cannot use the background jobs in Firefox. I needed to comment it out
  2. Service workers also failed.

Submission has been made to Firefox addons, but I am not confident it will be approved.

@nickytonline
Copy link
Member

I'd have to check this, but pre-service worker in Chrome extensions, you had to use a background.js file instead. I wonder if Firefox still requires that even though they are v3 for the manifest. 🤔 See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Background_scripts

@bdougie
Copy link
Member

bdougie commented Aug 3, 2023

Firefox approved the extension, but I think the above is causing an error.

https://addons.mozilla.org/en-US/firefox/addon/opensauced-ai/

#237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Status: No status
Development

No branches or pull requests

3 participants